fallback executor support #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We _need_ to do this before calling PreRun but it's also nice to do this before bothering the server.
|
For:
|
This is a breaking change and will affect Filecoin. However, filecoin is currently using this incorrectly anyways (breaking PreRun and PostRun).
This allows _trying_ to execute a command on a daemon, failing, and falling back on another executor.
Kubuxu
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds fallback support to the HTTP executor. That way, we can try to run a command locally if the daemon is offline.
Note: This is an API breaking change which I will bubble up to both go-ipfs and filecoin. Specifically,
http.NewClientnow returns anExecutor, not anhttp.Client. The correct way to use this client was to cast it to an executor.